New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api/types: remove deprecated type-aliases #47148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
area/api
status/2-code-review
impact/api
impact/changelog
impact/deprecation
kind/refactor
PR's that refactor, or clean-up code
labels
Jan 21, 2024
thaJeztah
force-pushed
the
api_remove_deprecated_types
branch
from
January 23, 2024 23:16
ac0fcb4
to
e0f52ee
Compare
These types were deprecated in c90229e (v25.0), and moved to api/types/system. This patch removes the aliases for; - api/types.Info - api/types.Commit - api/types.PluginsInfo - api/types.NetworkAddressPool - api/types.Runtime - api/types.SecurityOpt - api/types.KeyValue - api/types.DecodeSecurityOptions Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These types were deprecated in b688af2 (v25.0), and moved to api/types/checkpoint. This patch removes the aliases for; - api/types.CheckpointCreateOptions - api/types.CheckpointListOptions - api/types.CheckpointDeleteOptions - api/types.Checkpoint Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These types were deprecated in 48cacbc (v25.0), and moved to api/types/image. This patch removes the aliases for; - api/types.ImageDeleteResponseItem - api/types.ImageSummary - api/types.ImageMetadata Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
These types were deprecated in v25.0, and moved to api/types/container; This patch removes the aliases for; - api/types.ResizeOptions (deprecated in 95b92b1) - api/types.ContainerAttachOptions (deprecated in 30f09b4) - api/types.ContainerCommitOptions (deprecated in 9498d89) - api/types.ContainerRemoveOptions (deprecated in 0f77875) - api/types.ContainerStartOptions (deprecated in 7bce33e) - api/types.ContainerListOptions (deprecated in 9670d93) - api/types.ContainerLogsOptions (deprecated in ebef4ef) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
api_remove_deprecated_types
branch
from
January 24, 2024 00:27
e0f52ee
to
13f4694
Compare
laurazard
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/api
impact/api
impact/changelog
impact/deprecation
kind/refactor
PR's that refactor, or clean-up code
status/2-code-review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
api/types: remove deprecated system info types and functions
These types were deprecated in c90229e
(v25.0), and moved to api/types/system.
This patch removes the aliases for;
api/types: remove deprecated checkpoint-types
These types were deprecated in b688af2
(v25.0), and moved to api/types/checkpoint.
This patch removes the aliases for;
api/types: remove deprecated image-types
These types were deprecated in 48cacbc
(v25.0), and moved to api/types/image.
This patch removes the aliases for;
api/types: remove deprecated service-types
These types were deprecated in v25.0, and moved to api/types/swarm;
This patch removes the aliases for;
api/types: remove deprecated container-types
These types were deprecated in v25.0, and moved to api/types/container;
This patch removes the aliases for;
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)