New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: github.com/moby/buildkit v0.13.0-rc2 #47364
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f90b03e
go.mod: bump to go 1.21 and use local toolchain when vendoring
crazy-max 31545c3
vendor: github.com/moby/buildkit v0.13.0-rc2
vvoland dd69926
integration/build: Use new buildkit progressui
vvoland e68f712
integration/build: Use fsutil.NewFS
vvoland a79bb1e
builder-next/exporter: Sync with new signature
vvoland bc6d88c
cmd/dockerd: Fix overriding OTEL resource
vvoland b04a2da
builder/controller: Adjust NewWorkerOpt call
vvoland 59ad169
builder-next: Adjust to source changes
vvoland fa467ca
builder-next/mobyexporter: Use OptKeyName const
vvoland e01a1c5
builder/mobyexporter: Set `image.name` response key
vvoland 951e42c
builder-next: Replace ResolveImageConfig with ResolveSourceMetadata
vvoland f5722da
mobyexporter: Store temporary config descriptor
vvoland 60358bf
ci(buildkit): dedicated step to build test image
crazy-max 2d31532
otel: Default metrics protocol to http/protobuf
vvoland File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch!
Yeah it looks like this shouldn't be deleted.
I restored it as:
p.ref = ref.String()
because
ResolveImageConfig
no longer returns a reference.Looking at the old implementation, it didn't really change the ref that was passed as an argument.
The only place where it returned a different ref is where it went to the
(remotes.Resolver) Resolve()
, but it doesn't seem to change it either (at least thedocker
remote).