Set Created to 0001-01-01T00:00:00Z on older API versions

[tianon]

This matches the prior behavior before 2a6ff3c.

This also updates the Swagger documentation for the current version to note that the field might be the empty string and what that means.

Fixes #47368

(if accepted, this should be backported to 25.x)

Changelog

- API: Populate a missing `Created` field in `GET /images/{id}/json` with `0001-01-01T00:00:00Z` for API version <= 1.43.

[tianon]

Restarted GHA for https://github.com/moby/moby/actions/runs/7877638978/job/21494256308?pr=47374#step:6:1902 which looks like it's probably just flaky 😄

=== Failed
=== FAIL: libnetwork/networkdb TestNetworkDBCRUDTableEntries (7.60s)
    networkdb_test.go:309: Entry existence verification test failed for node2(a349cda6da8c)

[tianon]

/ # docker image inspect -f '{{ .Created }}' hivemq/hivemq-swarm:4.25.0

/ # DOCKER_API_VERSION=1.44 docker image inspect -f '{{ .Created }}' hivemq/hivemq-swarm:4.25.0

/ # DOCKER_API_VERSION=1.43 docker image inspect -f '{{ .Created }}' hivemq/hivemq-swarm:4.25.0
0001-01-01T00:00:00Z

[vvoland]

Would be also nice to address the wrong formatting in image list (could be in a follow up):
3. docker image list
=> CREATED = 54 years ago

[vvoland]

We should also note this change in version-history.md

[tianon]

Doh, good catch, I'll update (but I might not get to it today, so any other maintainer should feel free to take over 😅).

[thaJeztah]

Yeah, this is probably an OK stop-gap solution. I agree with the discussion on the ticket that we should consider making this an omitempty though (in future?).

[tianon]

I agree with the discussion on the ticket that we should consider making this an omitempty though (in future?).

Agreed! My first priority was addressing the backwards compatibility break for 25.x, and it seemed reasonable to decide it was "intentional" for 25.x and consider something more in 26.x (such as omitempty), but I do not feel strongly about changing this to delay committing to an actual break in behavior here until 26.x and applying my time.Time{} hack to 25.x's API version too so we can do both breaks intentionally at the same time in 26.x instead (ie, no "empty" intermediate state and go straight to omitempty in 26.x).

[thaJeztah]

LGTM

[neersighted]

Backport at #47387

[tianon]

Oh, can we apply omitempty conditionally on API version the future? If not, this might be our only chance to add it. 😅 🤦

[thaJeztah]

Now that we always set it for old API versions, I guess omitempty would be just.. that? We already shipped this API version so I didn't want to push too hard, but yeah, would love to have it

[tianon]

Well we could also revert/change this, apply the fix for 25.x API version too and add omitempty there.

[neersighted]

I think we can just add omitempty and keep this change; that will mean that API 1.44 will have no empty string and older API versions will have the bogus timestamp.

[tianon]

Did we get to that follow up, or is that still pending? 👀

[Subbaraman-Sowmya]

It is still pending ..not able to see the api-inspect-created

[neersighted]

@tianon I wasn't sure if we reached any consensus on that being a good idea; I can open a PR making that change.

[tianon]

I think if we're going to do it, we probably have to quickly -- maybe a PR is the best way to figure out if we have consensus? 😄