daemon: add a deprecation warning about links on the default nw #47427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature will be deprecated and removed in a couple releases, when we make the default bridge network just another bridge network. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
thaJeztah
reviewed
Feb 22, 2024
| @@ -113,6 +113,10 @@ func (daemon *Daemon) containerCreate(ctx context.Context, daemonCfg *configStor | |||
| return containertypes.CreateResponse{Warnings: warnings}, errdefs.InvalidParameter(err) | |||
| } | |||
|
|
|||
| if runtime.GOOS == "linux" && (opts.params.HostConfig.NetworkMode.IsDefault() || opts.params.HostConfig.NetworkMode.IsBridge()) && len(opts.params.HostConfig.Links) > 0 { | |||
| warnings = append(warnings, "Links on the default bridge network are deprecated and will be removed in a future release. You should use a custom network instead.") | |||
There was a problem hiding this comment.
Perhaps slightly shorter, and remove the pronoun;
Suggested change
| warnings = append(warnings, "Links on the default bridge network are deprecated and will be removed in a future release. You should use a custom network instead.") | |
| warnings = append(warnings, "Links on the default bridge network are deprecated and will be removed in a future release. Use a custom network instead.") |
What's the situation on Windows? Will we remove --link for the default network there as well?
|
@akerouanton PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This feature is deprecated and removed in a couple releases, when we make the default bridge network just another bridge network.
- How to verify it
- Description for the changelog