c8d/pull: Progress fixes #47432
Merged
c8d/pull: Progress fixes #47432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync access to the underlying `io.Writer` with a mutex. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
To align with the graphdrivers behavior and don't send unnecessary progress messages. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
added
area/distribution
process/cherry-pick
kind/bugfix
What is the issue seen for this? Is |
|
The writer itself is not protected. I noticed that after I experienced random failures when adding that additional progress update. This happens because |
neersighted
approved these changes
Feb 23, 2024
dmcgowan
approved these changes
Feb 23, 2024
cpuguy83
approved these changes
Feb 23, 2024
|
Failures are the expected ones (containerd snapshotter on Windows) |
akerouanton
added
process/cherry-picked
and removed
process/cherry-pick
process/cherry-pick/25.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Pulling fs layer(fixes issue in Docker Desktop)io.WriterinprogressOutputwith a mutexDownloadingwhen no progress was made yet- How I did it
See commits.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)