Dockerfile: Use CLI generated completions in the dev shell #47649
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Cobra-generated completion scripts for the CLI inside the dev container shell. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
added
status/2-code-review
kind/enhancement
thaJeztah
reviewed
Apr 3, 2024
| RUN echo "source /usr/share/bash-completion/bash_completion" >> /etc/bash.bashrc | ||
| RUN ln -s /usr/local/completion/bash/docker /etc/bash_completion.d/docker | ||
| # Include Docker's completion if mounted with DOCKER_BASH_COMPLETION_PATH |
There was a problem hiding this comment.
Somewhat wondering if we still need the DOCKER_BASH_COMPLETION_PATH code 🤔 It was added in #33801 to help with the manually written bash-completion scripts, so ... perhaps? That said, we also have the moby-bin image, so maybe we could create something in the docker/cli repository to help spin up a docker-in-docker environment with the latest daemon and the current CLI (and completion script)
There was a problem hiding this comment.
Yeah looks like we could remove it from moby and do that in the CLI which would be more appropriate place for shell completion development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Enabled Docker shell completions in the dev container shell.
This doesn't affect anything outside the development shell.
- How I did it
Use Cobra-generated completion scripts for the CLI inside the dev container shell.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)