Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix for illumos support #47657

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Minor fix for illumos support #47657

merged 1 commit into from
Apr 10, 2024

Conversation

siepkes
Copy link
Contributor

@siepkes siepkes commented Apr 1, 2024

illumos is the opensource continuation of OpenSolaris after Oracle closed to source it (again).

This change fixes builds breaking when trying to build illumos binaries which import this package.

For example use see: openbao/openbao#205.

@vvoland
Copy link
Contributor

vvoland commented Apr 2, 2024

Thank you for contributing! It appears your commit message is missing a DCO sign-off,
causing the DCO check to fail.

We require all commit messages to have a Signed-off-by line with your name
and e-mail (see "Sign your work"
in the CONTRIBUTING.md in this repository), which looks something like:

Signed-off-by: YourFirsName YourLastName <yourname@example.org>

There is no need to open a new pull request, but to fix this (and make CI pass),
you need to amend the commit(s) in this pull request, and "force push" the amended
commit.

Unfortunately, it's not possible to do so through GitHub's web UI, so this needs
to be done through the git commandline.

You can find some instructions in the output of the DCO check (which can be found
in the "checks" tab on this pull request), as well as in the Moby contributing guide.

Steps to do so "roughly" come down to:

  1. Set your name and e-mail in git's configuration:

    git config --global user.name "YourFirstName YourLastName"
    git config --global user.email "yourname@example.org"

    (Make sure to use your real name (not your GitHub username/handle) and e-mail)

  2. Clone your fork locally

  3. Check out the branch associated with this pull request

  4. Sign-off and amend the existing commit(s)

    git commit --amend --no-edit --signoff

    If your pull request contains multiple commits, either squash the commits (if
    needed) or sign-off each individual commit.

  5. Force push your branch to GitHub (using the --force or --force-with-lease flags) to update the pull request.

Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions!

illumos is the opensource continuation of OpenSolaris after Oracle
closed to source it (again).

For example use see: openbao/openbao#205.

Signed-off-by: Jasper Siepkes <siepkes@serviceplanet.nl>
@siepkes
Copy link
Contributor Author

siepkes commented Apr 3, 2024

D'oh! I actually read the contributor guidelines, noted the sign-off requirement and....still forgot to do it. I've updated the PR. Sorry about that!

@vvoland vvoland added this to the 27.0.0 milestone Apr 8, 2024
Copy link
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vvoland vvoland merged commit f9dfd13 into moby:master Apr 10, 2024
130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants