Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.0 backport] vendor: bump github.com/aws/aws-sdk-go-v2 to v1.24.1 #47724

Merged

Conversation

austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Apr 17, 2024

- What I did
Backports #47373 to 25.0

#47373 was added to unblock Buildkit upgrade; however, it also added support for log persistence for Docker containers in two AWS partitions. [Reference]

It would be great to have in Docker 25 as well.

- How I did it
For each commit:

git cherry-pick -xsS <commit_sha>

- How to verify it

- Description for the changelog

Updates AWS SDK Go v2 to v1.24.1 for AWS CloudWatch logging driver.

IMG_20240416_203113~2

In preparation for buildkit v0.13

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 999f90a)
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
…1.32.0

v1.33.0 is also available, but it would also cause
`github.com/aws/aws-sdk-go-v2` change from v1.24.1 to v1.25.0

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 70a4a9c)
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
(cherry picked from commit 2aa13e9)
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez austinvazquez marked this pull request as ready for review April 17, 2024 15:31
@austinvazquez
Copy link
Contributor Author

/cc @vvoland @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 7ac688a into moby:25.0 Apr 22, 2024
136 checks passed
@austinvazquez austinvazquez deleted the cherry-pick-aws-sdk-go-v2-update-to-25.0 branch April 22, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants