New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic /cmd entrypoint w/ cli support #5380
Conversation
To test this i added:
And running
|
#assignee=shykes |
@shykes ping? |
@alexlarsson sorry I got overrun. I would like to get this in for 0.11. @vieux would you mind taking over? (you can steal the PR to confirm). Thanks |
#assignee=vieux |
rebased to latest master |
This allows registering handlers after you've started using the engine, as well as setting hack envs. Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson)
If you do docker devmapper:resize -o Key=Value -o Foo=Bar plugin:op arg1 arg2 This will do a GET http request to /cmd/devmapper/resize with the arguments and options as keys. This will then try to spawn a job on the engine called "devmapper:resize" with the arg1, arg2, etc as arguments and the -o options as environment. Also, any graph driver implementing the engine.Installer interface will get installed on the engine when the daemon is created. This will be used by e.g. the devicemapper to allow driver-specific operations like pool resizing. Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson)
Updated to latest master. Any chance someone could take a look now? |
I'm closing this in favour of #4202, which contains the same commits. Its just too painful to keep rebasing both, and the dm ops allow you to test the core code. |
If you do
This will do a GET http request to /cmd/devmapper/resize with the arguments and options as keys. This will then try to spawn a job on the engine called "devmapper:resize" with the arg1, arg2, etc as arguments and the -o options as environment.
Also, any graph driver implementing the engine.Installer interface will get installed on the engine when the daemon is created.
This will be used by e.g. the devicemapper to allow driver-specific operations like pool resizing.
This PR is a break out from #4202, see comment there for the design input for this PR.