Store register refactor + vagrant fixes #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t shared folder, and setting some ENV variables
…ttle cleaner, and easier to reuse. Also added a unit test
jwhonce
pushed a commit
to jwhonce/docker
that referenced
this pull request
Mar 1, 2016
daemon: add no-volumes flag
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Oct 5, 2018
[18.09] backport: gd/dm: fix error message
vvoland
pushed a commit
to vvoland/moby
that referenced
this pull request
Aug 18, 2022
daemon/config: remove unused DefaultContainerdSnapshotter
crazy-max
pushed a commit
to crazy-max/moby
that referenced
this pull request
Sep 29, 2022
daemon/config: remove unused DefaultContainerdSnapshotter Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, there are two changes on the same pull request, I originally had them on two different branches and I couldn't figure out how to back out and either way, the fixes aren't related so I'm keeping it like this.
Vagrant is updated to work with the new single binary changes, and including new required packages, and added ENV variables to the .profile and added vagrant shared folder for easier mapping of files back and forth.
fs/store.Register refactor was just cleaning up the code a little, per Solomon's suggestions. unit test for Register was also added.