-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The installer completed page now contains information on next steps, so ... #6855
The installer completed page now contains information on next steps, so ... #6855
Conversation
@SvenDowideit this LGTM but I'm really curious: why are we still using busybox for testing successful installations (i.e., instead of Ubuntu, and the agreement to uniform the procedure across the docs as well)? Thanks! |
I keep using busybox because on my internet connection, it takes about a minute to download, whereas docker pulling ubuntu takes over 15minutes - which is pretty useless for a You're right, but its too late to change for the 1.1.0 installer release. I think I'll go get @tianon to make me a |
Hah, just use "tianon/true" for all your testing! More seriously though, as an outside observer (IANTM), I think sticking to Ubuntu+bash is much better for helping people grasp what it is that Docker's doing, since I'd wager that a very large number of people have no idea what "busybox" is, unless they've done some embedded work where a teeny tiny shell/userspace was required, and you don't want to be trying to explain what "busybox" is when you're in the middle of explaining what "Docker" itself is. |
@tianon y, thats why we made that decision - this was a finger memory thing - because I'm running this test many many times as I'm testing boot2docker, and it needs to be downloaded for each fresh install. I'm pretty serious about the |
What's the status of this? Can we closed? |
the status is waiting for LGTM's - its documenting the reality of the current installer release. |
The only change I'll see is the image replacement? Is that right? |
@SvenDowideit I don't understand the first bullet point on the new screen. Are you telling people how to quickly start with b2d? There's some context missing. If you can copy the text into here, I can revise it for you. |
@jamtur01 correct. Though as we're about to do a 1.1.1, I'll change the text to use ubuntu, and give @fredlf a chance to revise my words :) fred: https://github.com/boot2docker/osx-installer/blob/master/mpkg/Resources/en.lproj/Installed.html yes, this is right at the end of the installer, to tell them what next. |
…so is more useful than the intro Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@docker.com> (github: SvenDowideit)
LGTM |
LGTM, though I can tweak that text a little more after not looking at it for a few days.
|
@fredlf not now :) it'll be beginning of next month when there's a new release. That said - yes, make a PR and I'll merge it |
…-to-show-final-page The installer completed page now contains information on next steps, so ...
PR made! |
...is more useful than the intro
Docker-DCO-1.1-Signed-off-by: Sven Dowideit SvenDowideit@docker.com (github: SvenDowideit)