Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The installer completed page now contains information on next steps, so ... #6855

Conversation

SvenDowideit
Copy link
Contributor

...is more useful than the intro

Docker-DCO-1.1-Signed-off-by: Sven Dowideit SvenDowideit@docker.com (github: SvenDowideit)

@SvenDowideit
Copy link
Contributor Author

@jamtur01 @ostezer @fredlf

sorry @huslage I've gone and made the video mildly out of date again.

@ghost
Copy link

ghost commented Jul 5, 2014

@SvenDowideit this LGTM but I'm really curious: why are we still using busybox for testing successful installations (i.e., instead of Ubuntu, and the agreement to uniform the procedure across the docs as well)? Thanks!

@SvenDowideit
Copy link
Contributor Author

I keep using busybox because on my internet connection, it takes about a minute to download, whereas docker pulling ubuntu takes over 15minutes - which is pretty useless for a Hello World test to show that the install works.

You're right, but its too late to change for the 1.1.0 installer release.

I think I'll go get @tianon to make me a helloworld image on stackbrew in asm ala tianon/true

@tianon
Copy link
Member

tianon commented Jul 7, 2014

Hah, just use "tianon/true" for all your testing!

More seriously though, as an outside observer (IANTM), I think sticking to Ubuntu+bash is much better for helping people grasp what it is that Docker's doing, since I'd wager that a very large number of people have no idea what "busybox" is, unless they've done some embedded work where a teeny tiny shell/userspace was required, and you don't want to be trying to explain what "busybox" is when you're in the middle of explaining what "Docker" itself is.

@SvenDowideit
Copy link
Contributor Author

@tianon y, thats why we made that decision - this was a finger memory thing - because I'm running this test many many times as I'm testing boot2docker, and it needs to be downloaded for each fresh install. I'm pretty serious about the helloworld image - something that will say 'you docker is good, and can pull images' without taking so long that the user has moved away to work on non-docker things.

@jamtur01
Copy link
Contributor

jamtur01 commented Jul 8, 2014

What's the status of this? Can we closed?

@SvenDowideit
Copy link
Contributor Author

the status is waiting for LGTM's - its documenting the reality of the current installer release.

@jamtur01
Copy link
Contributor

jamtur01 commented Jul 8, 2014

The only change I'll see is the image replacement? Is that right?

@fredlf
Copy link
Contributor

fredlf commented Jul 8, 2014

@SvenDowideit I don't understand the first bullet point on the new screen. Are you telling people how to quickly start with b2d? There's some context missing.

If you can copy the text into here, I can revise it for you.

@SvenDowideit
Copy link
Contributor Author

@jamtur01 correct. Though as we're about to do a 1.1.1, I'll change the text to use ubuntu, and give @fredlf a chance to revise my words :)

fred: https://github.com/boot2docker/osx-installer/blob/master/mpkg/Resources/en.lproj/Installed.html

yes, this is right at the end of the installer, to tell them what next.

…so is more useful than the intro

Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@docker.com> (github: SvenDowideit)
@SvenDowideit
Copy link
Contributor Author

okely, @jamtur01 @fredlf @ostezer please see the 1.1.1 version of the image :)

@jamtur01
Copy link
Contributor

LGTM

@fredlf
Copy link
Contributor

fredlf commented Jul 15, 2014

LGTM, though I can tweak that text a little more after not looking at it for a few days.

  1. Make the first bullet into two sentences:
    "Run Boot2Docker (located in Applications), which will open a terminal. Then, start a test container with: ..."
  2. We can cut "from your terminal" in the second bullet. Seems unnecessary.

@SvenDowideit
Copy link
Contributor Author

@fredlf not now :) it'll be beginning of next month when there's a new release.

That said - yes, make a PR and I'll merge it

SvenDowideit pushed a commit that referenced this pull request Jul 15, 2014
…-to-show-final-page

The installer completed page now contains information on next steps, so ...
@SvenDowideit SvenDowideit merged commit b6e1cfc into moby:master Jul 15, 2014
@fredlf
Copy link
Contributor

fredlf commented Jul 15, 2014

PR made!

@SvenDowideit SvenDowideit deleted the update-osx-installer-image-to-show-final-page branch January 28, 2015 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants