Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused HostPath from /copy body #7543

Closed
wants to merge 1 commit into from
Closed

Conversation

duglin
Copy link
Contributor

@duglin duglin commented Aug 12, 2014

Signed-off-by: Doug Davis dug@us.ibm.com

The HostPath json property currently placed in the http body of the /containers/{id}/copy API is unused by the daemon/server so its misleading to include it - just cleaning something up that I noticed.

Signed-off-by: Doug Davis <dug@us.ibm.com>
@vieux
Copy link
Contributor

vieux commented Aug 12, 2014

NOT LGTM, the copy endpoint will be reworked soon. Such a change, even useless, would require an API bump. This is too mush trouble for nothing.

@vieux vieux closed this Aug 12, 2014
@duglin
Copy link
Contributor Author

duglin commented Aug 12, 2014

I'm not following. This doesn't require an API bump since the API only calls for the Resource field not the HostPath field to be passed in. IMO the client, right now, is actually violating the API by adding an extra, unused and unneeded, field.

@vieux
Copy link
Contributor

vieux commented Aug 12, 2014

ping @crosbymichael you added HostPath

@duglin
Copy link
Contributor Author

duglin commented Aug 12, 2014

@vieux, while we're waiting for @crosbymichael to respond, can you elaborate on the changes to 'copy' that are being planned? I was thinking about submitting a PR for option number 3 from my note: https://groups.google.com/forum/#!topic/docker-dev/TmaCiWIEyVk
and would be interesting in knowing the plans before I started.

@vieux
Copy link
Contributor

vieux commented Aug 12, 2014

@duglin copy working both ways i.e. container to host and host to container. See #6580

@duglin
Copy link
Contributor Author

duglin commented Aug 13, 2014

@crosbymichael any comment on this?

@crosbymichael
Copy link
Contributor

I think for future changes @vieux is right. We should keep it for now

@duglin
Copy link
Contributor Author

duglin commented Aug 13, 2014

Any idea why it was added to begin with when the server doesn't use/need it?

@duglin duglin deleted the CleanCP branch January 22, 2015 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants