Preserve extended attributes and acls on archlinux build #8404
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failure to do this means that file capabilites are not preserved in the image. Ping fails to work as a non-root user if cap_net_raw is capability is not set Signed-off-by: Dan Griffin <dgriffin@peer1.com>
|
@danjpgriffin I assume the tar command everywhere this is run will include those flags? |
|
also, related #6190 |
|
@vbatts Good question, as xattrs are still not well supported by many distros. However, it looks like the mkimage-arch.sh relies quite heavily on a working arch environment/tool chain (pacman, arch-chroot, pacstrap etc), and any arch environment should have a tar capable of --xattrs/--acl. |
danjpgriffin
force-pushed
the
master
branch
2 times, most recently
from
29ebb53
to
e857716
Compare
|
ping @tianon the alru man! |
|
@tianon you are now the owner of the goblet of shame |
|
Since this script won't actually work on non-Arch (without quite a bit of work), I think this is an acceptable change. LGTM |
tianon
added a commit
that referenced
this pull request
Nov 4, 2014
Preserve extended attributes and acls on archlinux build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure to do this means that file capabilites are not preserved in the image.
Ping fails to work as a non-root user if cap_net_raw is capability is not set
Signed-off-by: Dan Griffin dgriffin@peer1.com