Add docs for --dns-search=. #8839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -170,6 +170,7 @@ Four different options affect container domain name services. | |||
| When a container process attempts to access `host` and the search | |||
| domain `example.com` is set, for instance, the DNS logic will not | |||
| only look up `host` but also `host.example.com`. | |||
| Use `--dns-serach=.` to not set search domain. | |||
There was a problem hiding this comment.
Use --dns-search=. if you don't wish to set the search domain.
|
Thanks for this. Can you please update based on feedback. |
irachex
force-pushed
the
dns-search-doc
branch
from
c890c2b
to
4aacb25
Compare
|
@jamtur01 Thanks for your review. updated |
PR 6720 introduce that use `--dns-search=.` will not set `search` in `/etc/resolv.conf`. Signed-off-by: Huayi Zhang <irachex@gmail.com>
irachex
force-pushed
the
dns-search-doc
branch
from
4aacb25
to
36ffbd7
Compare
|
LGTM Ping @SvenDowideit @fredlf |
|
LGTM and many thanks for the contribution. |
| @@ -64,7 +64,7 @@ docker-create - Create a new container | |||
| Add a host device to the container (e.g. --device=/dev/sdc:/dev/xvdc:rwm) | |||
|
|
|||
| **--dns-search**=[] | |||
| Set custom DNS search domains | |||
| Set custom DNS search domains (Use --dns-search=. if you don't wish to set the search domain) | |||
There was a problem hiding this comment.
This needs a matching change in the code.
Signed-off-by: Huayi Zhang <irachex@gmail.com>
|
Docs LGTM - @crosbymichael @vieux @tiborvass @jfrazelle |
|
LGTM |
1 similar comment
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Oct 31, 2014
Add docs for --dns-search=.
SvenDowideit
pushed a commit
to SvenDowideit/docker
that referenced
this pull request
Nov 6, 2014
Add docs for --dns-search=. (cherry picked from commit 0f9f5f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6720 introduce that use
--dns-search=.will not setsearchin/etc/resolv.conf.