Scottstamp stale links pr carry #9682
Conversation
Fixed anchor links for Jessie/Wheezy (broken on docs.docker.com) Update debian.md Signed-off-by: Scott Stamp <scott@hypermine.com>
| @@ -55,6 +55,9 @@ docs-shell: docs-build | |||
| docs-release: docs-build | |||
| $(DOCKER_RUN_DOCS) -e OPTIONS -e BUILD_ROOT "$(DOCKER_DOCS_IMAGE)" ./release.sh | |||
|
|
|||
| docs-test: docs-build | |||
| $(DOCKER_RUN_DOCS) -p $(if $(DOCSPORT),$(DOCSPORT):)8000 "$(DOCKER_DOCS_IMAGE)" ./test.sh | |||
There was a problem hiding this comment.
Does the test script really expose the port?
There was a problem hiding this comment.
It shouldn't, if the script is running inside the container, it's already referencing localhost by default. It does return a list of addresses that would need to be fixed manually though, so it's probably best to ensure the docs are accessible from outside the container.
There was a problem hiding this comment.
na, that was just something i had when i was testing - so i could view the pages - that turned out to be pointless :)
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
SvenDowideit
force-pushed
the
scottstamp-stale-links-pr-carry
branch
from
6305d61
to
fbb9223
Compare
|
LGTM Many thanks, @scottstamp ! |
…carry Scottstamp stale links pr carry
|
@fredlf in the future, please let me LGTM LGTM |
…-pr-carry Scottstamp stale links pr carry (cherry picked from commit 5df189a) Signed-off-by: Sven Dowideit <SvenDowideit@docker.com> Docker-DCO-1.1-Signed-off-by: Fred Lifton <fred.lifton@docker.com> (github: fredlf)
|
@tianon Sorry about that, will do. Didn't occur to me that this change was outside docs' purview. Ooops. Mea culpa. |
squash and carry @scottstamp's PR #9646
and then fix the other things his script found.