Handle unresolvable domain names in isSecure to allow HTTP proxies to work as expected #9735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Vass <teabee89@gmail.com>
to allow HTTP proxies to work as expected. Fixes moby#9708 Signed-off-by: Tibor Vass <teabee89@gmail.com>
|
LGTM |
|
Tested. LGTM |
|
LGTM |
1 similar comment
|
LGTM |
tiborvass
added a commit
that referenced
this pull request
Dec 19, 2014
Handle unresolvable domain names in isSecure to allow HTTP proxies to work as expected
tiborvass
added a commit
to tiborvass/docker
that referenced
this pull request
Dec 19, 2014
If `--insecure-registry mydomain.com` was specified, it would match a registry at mydomain.com on any port. This was accidentally added in moby#9735 and is now being reverted. Signed-off-by: Tibor Vass <teabee89@gmail.com>
ColinHuang
pushed a commit
to fcwu/docker
that referenced
this pull request
Jan 5, 2015
If `--insecure-registry mydomain.com` was specified, it would match a registry at mydomain.com on any port. This was accidentally added in moby#9735 and is now being reverted. Signed-off-by: Tibor Vass <teabee89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9708
Replaces #9728
Ping @kdomanski @unclejack @ewindisch @dmp42 @dkjer @dmcgowan