Add a note that remote and Boot2Docker users should not type sudo #9836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps better to make a Nit; rename the include file to |
|
I'm always +1 for hyphens instead of underscores, especially since some In case you also wanted my opinion on organization, then I think I'm +1 on |
|
What @tianon said. |
| @@ -0,0 +1,3 @@ | |||
| > **Note:** if you are using a remote Docker daemon, such as Boot2Docker, | |||
| > then _do not_ type the `sudo` before the `docker` commands shown in the | |||
| > documentation examples. | |||
|
Agreed re: hyphens preferable. Also agree with a |
|
@SvenDowideit ping pong |
Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@docker.com> (github: SvenDowideit)
SvenDowideit
force-pushed
the
transcluded-no-sudo-note
branch
from
e4b0265
to
d5df948
Compare
|
LGTM |
|
Thanks Sven! |
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Jan 14, 2015
Add a note that remote and Boot2Docker users should not type sudo
SvenDowideit
pushed a commit
to SvenDowideit/docker
that referenced
this pull request
Jan 27, 2015
Add a note that remote and Boot2Docker users should not type sudo (cherry picked from commit 71ab2ef) Docker-DCO-1.1-Signed-off-by: Michael Crosby <crosby.michael@gmail.com> (github: SvenDowideit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker-DCO-1.1-Signed-off-by: Sven Dowideit SvenDowideit@docker.com (github: SvenDowideit)
Closes #9808
and I've implemented a quick transclusion so
{{ include "filename" }}will be replaced by that content.