Add options to bash completion and sort options #9863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tianon @jfrazelle ping |
|
Wow, that sorting commit looks like it was a lot of work! Nice! 👍 |
| ;; | ||
| *) | ||
| __docker_image_repos_and_tags_and_ids | ||
| esac |
There was a problem hiding this comment.
Can we add the ;; in this *) block too, just for consistency? 👼
There was a problem hiding this comment.
yes, sure. Thanks for spotting this.
|
Other than my one tiny nit, LGTM! Very nice work. ⭐ |
|
Yayyyy You came back for more! LGTM after that fix :) |
albers
force-pushed
the
bash-completion
branch
from
c8c48ed
to
70161b4
Compare
|
Fixed & rebased. Thanks for reviewing. |
Signed-off-by: Harald Albers <github@albersweb.de>
This introduces a sort order for options: Arrange options sorted alphabetically by long name with the short options immediately following their corresponding long form. Signed-off-by: Harald Albers <github@albersweb.de>
|
Awesome, thanks so much @albers ❤️ This is haaaawt 👍 |
|
LGTM |
tianon
added a commit
that referenced
this pull request
Jan 1, 2015
Add options to bash completion and sort options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following options:
When implementing, I found it hard to spot the appropriate places for the options because there was no consistent sort order. Therefore I added a refactoring step that introduces a new sort order:
Arrange options sorted alphabetically by long name with the short options immediately following their corresponding long form.
This also removes support for the following deprecated options: