doc: Standardise JSON examples #9884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed: * Invalid JSON * Inconsistent spacing at colon Expression for binary data streams (line 468 vs. 1474) remain inconsistent. Could fix that too, if you like. Signed-off-by: Lorenz Leutgeb <lorenz.leutgeb@gmail.com>
lorenzleutgeb
changed the title
|
LGTM |
This is:
git format-patch -1 --stdout HEAD \
| patch -p1 docs/sources/reference/api/docker_remote_api_v1.*.md
Applying the changes I initially made on the docs for v1.15 to all
other versions led to acceptable results.
Signed-off-by: Lorenz Leutgeb <lorenz.leutgeb@gmail.com>
|
@SvenDowideit I used my changes to patch the other files too. Some hunks could not be applied though. My guess would be that's because the docs evolved with the API over time and therefore do not match perfectly. Still the case of invalid JSON was fixed a few times over. |
|
pretty!! |
|
Ping @fredlf |
|
@FlowLo awesome! merci-much |
SvenDowideit
added a commit
that referenced
this pull request
Jan 6, 2015
doc: Standardise JSON examples
SvenDowideit
added a commit
to SvenDowideit/docker
that referenced
this pull request
Jan 27, 2015
doc: Standardise JSON examples (cherry picked from commit ceedace) Conflicts: docs/sources/reference/api/docker_remote_api_v1.17.md Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@users.noreply.github.com> (github: SvenDowideit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly whitespace. Fixed:
Expressions for binary data streams (line 468 vs. 1474) remain inconsistent. Could fix that too, if you like.
I can also look at v1.16 if requested.