doc: Improve article on HTTPS #9896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not encrypt private keys in the first place, if the encryption is stripped anyway. Signed-off-by: Lorenz Leutgeb <lorenz.leutgeb@gmail.com>
Use AES (the successor of DES) to encrypt private key. Further reading: * http://csrc.nist.gov/publications/nistpubs/800-131A/sp800-131A.pdf * https://ssllabs.com/downloads/SSL_TLS_Deployment_Best_Practices.pdf "3DES provides about 112 bits of security. This is below the recommended minimum of 128 bits, but it's still strong enough. A bigger practical problem is that 3DES is much slower than the alternatives. Thus, we don't recommend it for performance reasons, but it can be kept at the end of the cipher list for interoperability with very old clients." * http://csrc.nist.gov/publications/nistpubs/800-67-Rev1/SP-800-67-Rev1.pdf Use SHA256 for our CA. This avoids accidental use of SHA1 or MD5 which could be default values. Signed-off-by: Lorenz Leutgeb <lorenz.leutgeb@gmail.com>
With -CAcreateserial the serial file will be automatically created and initialized if it is missing. Signed-off-by: Lorenz Leutgeb <lorenz.leutgeb@gmail.com>
Using --insecure is (you guessed it) *insecure* as the server side certificate is not being validated. To offer the same degree of security as invocations of the docker client in "Secure by default" with cURL, the trusted CA certificate must be supplied. Signed-off-by: Lorenz Leutgeb <lorenz.leutgeb@gmail.com>
|
LGTM from a language/docs point of view, but I need to know it's been validated before we merge. @SvenDowideit did you run through the procedure? I'll do it if not. |
|
LGTM |
|
Assuming the changes I provided up until now are validated, I'd like to drive this a bit further: Would you like to see
|
|
I'm working through it now.. |
|
ok, i've tested, and it works in debian - @FlowLo |
|
yes, please make a follow-on PR - I'm going to merge LGTM :) |
SvenDowideit
added a commit
that referenced
this pull request
Jan 7, 2015
doc: Improve article on HTTPS
SvenDowideit
added a commit
to SvenDowideit/docker
that referenced
this pull request
Jan 27, 2015
doc: Improve article on HTTPS (cherry picked from commit 2f588c6) Docker-DCO-1.1-Signed-off-by: Sven Dowideit <SvenDowideit@users.noreply.github.com> (github: SvenDowideit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My editor deleted some whitespace, but I think that's reasonable.