Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build --pull and evenets --filter flags to the docs for 1.4 #9941

Merged
merged 1 commit into from
Jan 16, 2015

Conversation

SvenDowideit
Copy link
Contributor

Signed-off-by: Sven Dowideit SvenDowideit@home.org.au

closes #9912

this should go into a docs-update

@fredlf @jamtur01

@jamtur01
Copy link
Contributor

jamtur01 commented Jan 7, 2015

LGTM

@SvenDowideit
Copy link
Contributor Author

@fredlf

@@ -27,6 +28,9 @@ and Docker images will report:
**--help**
Print usage statement

**-f**, **--filter**=[]
Provide filter values (i.e. 'event=stop')

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a comma after i.e.

@fredlf
Copy link
Contributor

fredlf commented Jan 15, 2015

LGTM once my comma nit is picked.

Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit
Copy link
Contributor Author

@fredlf can you please check all my i.e.,'s :)

@fredlf
Copy link
Contributor

fredlf commented Jan 15, 2015

Docs LGTM. @jfrazelle Why is this "docs only"? There are code changes here to client commands.

@jessfraz
Copy link
Contributor

might have happened after the initial push, we can always make modifications to the bot ;) this is v0.1 lol

@SvenDowideit
Copy link
Contributor Author

@vieux @jfrazelle

@jessfraz
Copy link
Contributor

LGTM

jessfraz pushed a commit that referenced this pull request Jan 16, 2015
Add build --pull and evenets --filter flags to the docs for 1.4
@jessfraz jessfraz merged commit 00d1915 into moby:master Jan 16, 2015
SvenDowideit pushed a commit to SvenDowideit/docker that referenced this pull request Jan 27, 2015
Add build --pull and evenets --filter flags to the docs for 1.4
(cherry picked from commit 00d1915)

Conflicts:
	api/client/commands.go
	contrib/completion/fish/docker.fish
	docs/man/docker-build.1.md
	docs/man/docker-events.1.md
	docs/sources/reference/commandline/cli.md

Docker-DCO-1.1-Signed-off-by: Jessie Frazelle <jfrazelle@users.noreply.github.com> (github: SvenDowideit)
@SvenDowideit SvenDowideit deleted the build-pull-option-docs branch January 28, 2015 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build switch "pull=true" not listed in online documentation
4 participants