Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a parser error where an empty RUN statement would cause a panic #9980

Merged
merged 1 commit into from
Jan 9, 2015
Merged

Fix a parser error where an empty RUN statement would cause a panic #9980

merged 1 commit into from
Jan 9, 2015

Conversation

erikh
Copy link
Contributor

@erikh erikh commented Jan 8, 2015

Fix a parser error where an empty RUN statement would cause a panic
09e3467 
Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <github@hollensbe.org> (github: erikh)
@tonistiigi
Copy link
Member

FYI, RUN [] also panics.

@erikh
Copy link
Contributor Author

erikh commented Jan 8, 2015

interesting. I'll look into it.

@erikh
Copy link
Contributor Author

erikh commented Jan 8, 2015

let's do this in another patch though.

@unclejack
Copy link
Contributor

LGTM

2 similar comments
@icecrime
Copy link
Contributor

icecrime commented Jan 8, 2015

LGTM

@duglin
Copy link
Contributor

duglin commented Jan 9, 2015

LGTM

duglin added a commit that referenced this pull request Jan 9, 2015
@duglin
Merge pull request #9980 from erikh/parser-with-no-command
32cde64 
Fix a parser error where an empty RUN statement would cause a panic
@duglin duglin merged commit 32cde64 into moby:master Jan 9, 2015
@SvenDowideit SvenDowideit mentioned this pull request Jan 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erikh @tonistiigi @unclejack @icecrime @duglin