docker ps --filter exited=status should not show running containers
#9985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if len(filt_exited) > 0 && container.Running { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
I don't think that's the best possible fix for the issue. I would do this instead:
@@ -98,10 +98,10 @@ func (daemon *Daemon) Containers(job *engine.Job) engine.Status {
return errLast
}
}
- if len(filt_exited) > 0 && !container.Running {
+ if len(filt_exited) > 0 {
should_skip := true
for _, code := range filt_exited {
- if code == container.ExitCode {
+ if !container.Running && code == container.ExitCode {
should_skip = false
break
}
jessfraz
force-pushed
the
fix-exited-filter-should-not-show-running
branch
from
aec48e8
to
81f8402
Compare
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)
|
LGTM |
1 similar comment
|
LGTM |
vbatts
added a commit
that referenced
this pull request
Jan 12, 2015
…show-running `docker ps --filter exited=status` should not show running containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker-DCO-1.1-Signed-off-by: Jessica Frazelle jess@docker.com (github: jfrazelle)