dispatcher: Give a couple of minutes for nodes to recover on re-election #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will fix moby/moby#25017 /cc @thaJeztah |
|
Seems reasonable as a stopgap. LGTM Let's file an issue about improving this, though. |
|
@aluzzardi Test failure on dispatcher, seems related 😕 (need to update the test to reflect the change I guess) |
|
Test is failing. I can reproduce the test failure locally. |
|
Yep. Damn, this is much bigger |
|
The tests hardcode a wait of 500 ms |
Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
aluzzardi
force-pushed
the
dispatcher-unknown-extra-graceperiod
branch
from
56cc6d6
to
8b7de39
Compare
|
PTAL |
Current coverage is 54.89% (diff: 100%)@@ master #1238 diff @@
==========================================
Files 78 78
Lines 12403 12406 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6817 6810 -7
- Misses 4651 4658 +7
- Partials 935 938 +3
|
|
LGTM |
This was referenced Jul 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @LK4D4 @aaronlehmann
Signed-off-by: Andrea Luzzardi aluzzardi@gmail.com