picker: modify constants so donweights occur rarely #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LK4D4 I have a branch I'm working on to address this. I think we need to change the default observation to be larger than 1. I'm also going to steal your test. |
| @@ -165,7 +165,7 @@ const ( | |||
| // See | |||
| // https://en.wikipedia.org/wiki/Exponential_smoothing#Basic_exponential_smoothing | |||
| // for details. | |||
| remoteWeightSmoothingFactor = 0.7 | |||
| remoteWeightSmoothingFactor = 0.999 | |||
There was a problem hiding this comment.
Actually, we want this around 0.5 or it will have no effect. Remove this line and we'll merge and then I'll submit a follow up.
|
@stevvooe cool, thank you! |
Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
|
LGTM |
Current coverage is 54.82% (diff: 100%)@@ master #1266 diff @@
==========================================
Files 78 78
Lines 12418 12403 -15
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6820 6800 -20
- Misses 4658 4660 +2
- Partials 940 943 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to keep diffs relatively small, just enough to fix a situation with hard-crashed managers.
ping @aaronlehmann @stevvooe