scheduler: Properly handle dead tasks when populating data structures #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in setupTasksList was incorrect. It treated dead tasks as if they were running. We didn't catch this because this function only runs on leader failover. Corrected the function and added a test. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Current coverage is 54.85% (diff: 100%)@@ master #1299 diff @@
==========================================
Files 78 78
Lines 12468 12467 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6863 6839 -24
- Misses 4661 4677 +16
- Partials 944 951 +7
|
|
nice find! SGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in
setupTasksListwas incorrect. It treated dead tasks as ifthey were running. We didn't catch this because this function only runs
on leader failover.
Corrected the function and added a test.
Fixes #1296
cc @thaJeztah @LK4D4 @dongluochen