[17.03] Increase gRPC request timeout to 20 seconds when sending snapshots #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshulpundir
approved these changes
Oct 11, 2017
|
CI failure does not seem related, all the issues seem to be style/formatting issues. |
anshulpundir
suggested changes
Oct 11, 2017
There was a problem hiding this comment.
My bad, I hit approve too soon.
CI failure does not seem related, all the issues seem to be style/formatting issues.
We'll need to port over the fixes for the lint failures:
aa2c48b
|
Lint errors fixed in #2418 |
anshulpundir
approved these changes
Oct 23, 2017
(cherry picked from commit e3e2821) Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
nishanttotla
force-pushed
the
increase-grpc-timeout-17.03
branch
from
58ca4fa
to
9b67599
Compare
Codecov Report
@@ Coverage Diff @@
## bump_v17.03 #2406 +/- ##
===============================================
- Coverage 55.78% 55.43% -0.35%
===============================================
Files 102 102
Lines 21532 21544 +12
===============================================
- Hits 12011 11943 -68
- Misses 8368 8446 +78
- Partials 1153 1155 +2 |
|
LGTM |
|
I know @davidwilliamson tested this manually, but I am not sure there is an automated test for this. cc @antonybichon17 |
fcrisciani
pushed a commit
to fcrisciani/swarmkit
that referenced
this pull request
Jan 19, 2018
…17.03 [17.03] Increase gRPC request timeout to 20 seconds when sending snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2391
I had to manually make these changes, since the cherry-pick wasn't clean. I think this needs a code review.
cc @anshulpundir @aaronlehmann @andrewhsu @thaJeztah
Signed-off-by: Nishant Totla nishanttotla@gmail.com