update to go 1.18 #3070
Merged
update to go 1.18 #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, so this bit works; moving it out of draft @dperny PTAL |
thaJeztah
force-pushed
the
bump_go_118
branch
8 times, most recently
from
014bf35
to
ec32a0b
Compare
This was referenced Nov 18, 2022
thaJeztah
force-pushed
the
bump_go_118
branch
from
ec32a0b
to
e2b0631
Compare
thaJeztah
force-pushed
the
bump_go_118
branch
from
e2b0631
to
a67015c
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_go_118
branch
from
a67015c
to
3e6e518
Compare
|
@neersighted @dperny PTAL (I'll continue looking at #3085 after this) |
corhere
approved these changes
Nov 22, 2022
|
Thx! Bringing this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(let's see if this is the cause of the failures in #3069