Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: go-mod-vendor: fix copying of gogo/protobuf #3088

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Nov 19, 2022

Possibly it's using a non-standard location;

cp: cannot stat '/home/circleci/.go_workspace:/usr/local/go_workspace/pkg/mod/github.com/gogo/protobuf@v1.3.2/protobuf': No such file or directory
make: *** [direct.mk:146: go-mod-vendor] Error 1

So, using GOMODCACHE path instead of trying to construct our own.

Possibly it's using a non-standard location;

    cp: cannot stat '/home/circleci/.go_workspace:/usr/local/go_workspace/pkg/mod/github.com/gogo/protobuf@v1.3.2/protobuf': No such file or directory
    make: *** [direct.mk:146: go-mod-vendor] Error 1

So, using GOMODCACHE path instead of trying to construct our own.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Hm... flaky test?

--- FAIL: TestRaftRestartClusterSimultaneously (12.22s)
    testutils.go:97: 
        	Error Trace:	testutils.go:97
        	            				raft_test.go:626
        	            				raft_test.go:664
        	Error:      	Received unexpected error:
        	            	did not find a ready leader in member list
        	            	github.com/moby/swarmkit/v2/manager/state/raft/testutils.WaitForCluster.func1
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/testutils/testutils.go:74
        	            	github.com/moby/swarmkit/v2/testutils.PollFuncWithTimeout
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/testutils/poll.go:22
        	            	github.com/moby/swarmkit/v2/testutils.PollFunc
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/testutils/poll.go:36
        	            	github.com/moby/swarmkit/v2/manager/state/raft/testutils.WaitForCluster
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/testutils/testutils.go:60
        	            	github.com/moby/swarmkit/v2/manager/state/raft_test.testRaftRestartCluster
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/raft_test.go:626
        	            	github.com/moby/swarmkit/v2/manager/state/raft_test.TestRaftRestartClusterSimultaneously
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/raft_test.go:664
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1259
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1581
        	            	polling failed
        	            	github.com/moby/swarmkit/v2/testutils.PollFuncWithTimeout
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/testutils/poll.go:28
        	            	github.com/moby/swarmkit/v2/testutils.PollFunc
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/testutils/poll.go:36
        	            	github.com/moby/swarmkit/v2/manager/state/raft/testutils.WaitForCluster
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/testutils/testutils.go:60
        	            	github.com/moby/swarmkit/v2/manager/state/raft_test.testRaftRestartCluster
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/raft_test.go:626
        	            	github.com/moby/swarmkit/v2/manager/state/raft_test.TestRaftRestartClusterSimultaneously
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/raft_test.go:664
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1259
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1581
        	Test:       	TestRaftRestartClusterSimultaneously
FAIL

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f34bfc0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3088   +/-   ##
=========================================
  Coverage          ?   62.03%           
=========================================
  Files             ?      156           
  Lines             ?    24618           
  Branches          ?        0           
=========================================
  Hits              ?    15271           
  Misses            ?     7751           
  Partials          ?     1596           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thaJeztah
Copy link
Member Author

Thx! Let me bring this one in

@thaJeztah thaJeztah merged commit bdaab74 into moby:master Nov 19, 2022
@thaJeztah thaJeztah deleted the fix_gogo_protobuf branch November 19, 2022 22:17
@thaJeztah thaJeztah mentioned this pull request Nov 19, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants