Change idm.New() signature #3130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
Both datastore and id arguments have been removed from idm.New() signature (1st & 2nd arguments). Signed-off-by: Albin Kerouanton <albinker@gmail.com>
akerouanton
force-pushed
the
change-idm-signature
branch
from
46fc36f
to
7108d97
Compare
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Jun 29, 2023
This new idm constructor is temporarily added to make it possible to change swarmkit without hitting the dependency cycle that requires moby/swarmkit#3130 to revendor a fork of moby/moby. Once swarmkit uses this new constructor, we'll be able to change idm.New() to match idm.NewWithNoStore(). Signed-off-by: Albin Kerouanton <albinker@gmail.com>
akerouanton
added a commit
to akerouanton/docker
that referenced
this pull request
Jun 29, 2023
This new idm constructor is temporarily added to make it possible to change swarmkit without hitting the dependency cycle that requires moby/swarmkit#3130 to revendor a fork of moby/moby. Once swarmkit uses this new constructor, we'll be able to change idm.New() to match idm.NewWithNoStore(). Signed-off-by: Albin Kerouanton <albinker@gmail.com>
|
This PR has been superseded by #3141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How to test it
CI is green.