Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce direct imports of logrus #3148

Merged
merged 2 commits into from
Aug 7, 2023
Merged

reduce direct imports of logrus #3148

merged 2 commits into from
Aug 7, 2023

Conversation

thaJeztah
Copy link
Member

log: define Fields type as alternative for logrus.Fields

reduce direct imports of logrus

swap logrus types for their swarmkit/v2/logs alternatives

- What I did

- How I did it

- How to test it

- Description for the changelog

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
swap logrus types for their swarmkit/v2/logs alternatives

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

Codecov Report

Merging #3148 (cd9912a) into master (88a8e0a) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 66.15%.

@@            Coverage Diff             @@
##           master    #3148      +/-   ##
==========================================
- Coverage   61.71%   61.70%   -0.01%     
==========================================
  Files         155      155              
  Lines       31145    31143       -2     
==========================================
- Hits        19221    19217       -4     
- Misses      10381    10382       +1     
- Partials     1543     1544       +1     

@thaJeztah
Copy link
Member Author

@thaJeztah
Copy link
Member Author

@dperny @AkihiroSuda @corhere PTAL

@dperny
Copy link
Collaborator

dperny commented Aug 7, 2023

We should have done this a long time ago. Good idea.

@dperny dperny merged commit 9afd813 into moby:master Aug 7, 2023
7 checks passed
@thaJeztah thaJeztah deleted the loggggggs branch August 7, 2023 16:40
@thaJeztah
Copy link
Member Author

I think there's still some spots where it's used, but at least this brings us "somewhat" there. Further discussion also happening in containerd on this PR;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants