Remove the "shutdown" protocol used for forwarding ports over Hyper-V sockets #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djs55
force-pushed
the
shutdown
branch
4 times, most recently
from
f71259d
to
dbaa9d9
Compare
This has a new shutdown API. Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave.scott@docker.com>
Previously we used a custom protocol on top of Hyper-V sockets because they didn't support `shutdown`. With modern Windows and modern Linux the `shutdown` works (at least when the connections are initiated from the host) and therefore the Go `linuxkit/virtsock` library has dropped the custom protocol. Since we're talking to `vpnkit-forwarder` using `linuxkit/virtsock` we must drop the custom protocol too. This uses an experimental version of `mirage/ocaml-hvsock` with support for syscall-based `shutdown`. Signed-off-by: David Scott <dave.scott@docker.com>
|
The hvsock API has changed. I'll close this PR and open a fresh one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used a custom protocol on top of Hyper-V sockets because they didn't support
shutdown. With modern Windows and modern Linux theshutdownworks (at least when the connections are initiated from the host) and therefore the Golinuxkit/virtsocklibrary has dropped the custom protocol. Since we're talking tovpnkit-forwarderusinglinuxkit/virtsockwe must drop the custom protocol too.This uses an experimental version of
mirage/ocaml-hvsockwith support for syscall-basedshutdown.