Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "shutdown" protocol used for forwarding ports over Hyper-V sockets #418

Closed
wants to merge 3 commits into from
Closed

Remove the "shutdown" protocol used for forwarding ports over Hyper-V sockets #418

wants to merge 3 commits into from

Commits on Sep 13, 2018

  1. hvsock: use an unreleased snapshot of 1.0.5 

    This has a new shutdown API.

Signed-off-by: David Scott <dave.scott@docker.com>
    @djs55
    djs55 committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    f051404 View commit details
    Browse the repository at this point in the history

  2. AUTO: Update upstream packages 

    Signed-off-by: David Scott <dave.scott@docker.com>
    @djs55
    djs55 committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    6d00b09 View commit details
    Browse the repository at this point in the history

  3. Remove the Hyper-V socket "shutdown" protocol 

    Previously we used a custom protocol on top of Hyper-V sockets because
they didn't support `shutdown`. With modern Windows and modern Linux the
`shutdown` works (at least when the connections are initiated from the
host) and therefore the Go `linuxkit/virtsock` library has dropped the
custom protocol. Since we're talking to `vpnkit-forwarder` using
`linuxkit/virtsock` we must drop the custom protocol too.

This uses an experimental version of `mirage/ocaml-hvsock` with support
for syscall-based `shutdown`.

Signed-off-by: David Scott <dave.scott@docker.com>
    @djs55
    djs55 committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    18e360b View commit details
    Browse the repository at this point in the history