Minor Regex Change #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What exactly does this do? |
|
Basically nothing. The script continues to work. The only change is that regex is not not capturing those useless groups (the commands). I think (not entirely sure) that this might make it faster, but probably only for a fraction of a second. Anyways. Makes the regex code cleaner. |
|
It can't auto merge, so merge the current master into this branch, resolve all conflicts, and then update this so I can merge it into master. |
irapha
added a commit
that referenced
this pull request
Aug 6, 2014
Minor Regex Change. Conflict fixed
|
WAIT DONT MERGE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change. All I really want is to get rid of this branch so I can open a new one for the soundcloud script.