Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motd to greeting #17

Merged
merged 3 commits into from
Aug 28, 2021
Merged

Motd to greeting #17

merged 3 commits into from
Aug 28, 2021

Conversation

msdobrescu
Copy link
Contributor

motd breaks Gnome greeting display, so keep the feature as a greeting instead, should have the same effect except for Gnome greeting. If accepted, could/should be propagated in mocaccino-funtoo and other similar projects.
Two topics are opened for the same issue:
mocaccinoOS/mocaccino#11
mocaccinoOS/desktop#125
My issue opened on GDM side: https://gitlab.gnome.org/GNOME/gdm/-/issues/718

@msdobrescu
motd moved to profile.d
a35edbc 
motd breaks Gnome greeting display, so keep the feature as a greeting instead, should have the same effect except for Gnome greeting. If accepted, could/should be propagated in mocaccino-funtoo and other similar projects.
Two topics are opened for the same issue:
mocaccinoOS/mocaccino#11
https://github.com/mocaccinoOS/desktop/issues/125
My issue opened on GDM side: https://gitlab.gnome.org/GNOME/gdm/-/issues/718
@msdobrescu
greeting.sh echo in one line
e32234c
@joostruis joostruis requested a review from mudler August 27, 2021 17:19
mudler
mudler approved these changes Aug 28, 2021
View reviewed changes
Copy link
Contributor

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still thorn by the fact that this will be still an issue if an user touches his motd, but I'm fine with this change, thanks!

mudler
mudler requested changes Aug 28, 2021
View reviewed changes
Copy link
Contributor

@mudler mudler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the package version needs to be bumped, otherwise there is no new version to be installed 🙂

@msdobrescu
Copy link
Contributor Author

@mudler, on one hand, anybody could setup his system to whatever he needs, mOS offers just a default setup.
On other hand, there is little work to do more on this.
What about this one?

@mudler
Copy link
Contributor

mudler commented Aug 28, 2021

I'm fine with this change, just needs the package version to be bumped.. we can always document this in our docs :)

@msdobrescu msdobrescu requested a review from mudler August 28, 2021 08:14
@mudler
Copy link
Contributor

mudler commented Aug 28, 2021

Perfect! Thanks

@mudler mudler merged commit 417bb82 into mocaccinoOS:master Aug 28, 2021
@msdobrescu
Copy link
Contributor Author

Thank you!

@msdobrescu msdobrescu deleted the motd-to-greeting branch August 28, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler Awaiting requested review from mudler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msdobrescu @mudler