Merge pull request #2181 from JustATrick/fix-check-leaks

fix check-leaks to catch a leak whose name begins with 'd'
mochajs · Aug 28, 2016 · 1605548 · 1605548
2 parents 0aa932b + a419b9f
commit 1605548
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/runner.js b/lib/runner.js
@@ -892,7 +892,7 @@ function hasOnly(suite) {
 function filterLeaks(ok, globals) {
   return filter(globals, function(key) {
     // Firefox and Chrome exposes iframes as index inside the window object
-    if (/^d+/.test(key)) {
+    if (/^\d+/.test(key)) {
       return false;
     }
 

diff --git a/test/runner.js b/test/runner.js
@@ -179,6 +179,15 @@ describe('Runner', function(){
       });
       runner.checkGlobals(test);
     })
+
+    it('should emit "fail" when a global beginning with d is introduced', function(done) {
+      global.derp = 'bar';
+      runner.on('fail', function(test, err){
+        delete global.derp;
+        done();
+      });
+      runner.checkGlobals('im a test');
+    });
   })
 
   describe('.hook(name, fn)', function(){