deprecate this.skip for after/-Each hooks

mochajs · Feb 9, 2019 · 92431bb · 92431bb
1 parent 21ba5ce
commit 92431bb
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/lib/runner.js b/lib/runner.js
@@ -1,6 +1,7 @@
 'use strict';
 
 var EventEmitter = require('events').EventEmitter;
+var format = require('util').format;
 var Pending = require('./pending');
 var utils = require('./utils');
 var inherits = utils.inherits;
@@ -377,6 +378,15 @@ Runner.prototype.hook = function(name, fn) {
       }
       if (err) {
         if (err instanceof Pending) {
+          if (name === HOOK_TYPE_AFTER_EACH || name === HOOK_TYPE_AFTER_ALL) {
+            utils.deprecate(
+              format(
+                "skipping a test within an '%s' hook is DEPRECATED and will be removed from a future version of Mocha. " +
+                  "Use 'return' instead to exit hook abortively.",
+                name
+              )
+            );
+          }
           if (name === HOOK_TYPE_BEFORE_EACH || name === HOOK_TYPE_AFTER_EACH) {
             self.test.pending = true;
           } else {