preserve-symlinks{-main} flags (#3900)

Update unit test for Node-12 compatibility.
mochajs · May 8, 2019 · 9b00fed · 9b00fed
1 parent aed20bd
commit 9b00fed
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/test/node-unit/cli/node-flags.spec.js b/test/node-unit/cli/node-flags.spec.js
@@ -35,9 +35,12 @@ describe('node-flags', function() {
       it('should return true for flags starting with "preserve-symlinks"', function() {
         expect(isNodeFlag('preserve-symlinks'), 'to be true');
         expect(isNodeFlag('preserve-symlinks-main'), 'to be true');
-        // XXX this is not true in some newer versions of Node.js.  figure out where
-        // this changed.
-        expect(isNodeFlag('preserve_symlinks'), 'to be false');
+        // Node >= v12 both flags exist in process.allowedNodeEnvironmentFlags
+        const nodeVersion = parseInt(process.version.match(/^v(\d+)\./)[1], 10);
+        expect(
+          isNodeFlag('preserve_symlinks'),
+          nodeVersion >= 12 ? 'to be true' : 'to be false'
+        );
       });
 
       it('should return true for flags starting with "harmony-" or "harmony_"', function() {