Merge pull request #2101 from jkimbo/non-string-error-messages

Non string error messages
mochajs · Feb 19, 2016 · 9c41051 · 9c41051
2 parents 0543798 + e0a43d2
commit 9c41051
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/lib/reporters/base.js b/lib/reporters/base.js
@@ -170,8 +170,8 @@ exports.list = function(failures) {
     var msg;
     var err = test.err;
     var message;
-    if (err.message) {
-      message = err.message;
+    if (err.message && typeof err.message.toString === 'function') {
+      message = err.message + '';
     } else if (typeof err.inspect === 'function') {
       message = err.inspect() + '';
     } else {

diff --git a/test/reporters/base.js b/test/reporters/base.js
@@ -1,3 +1,5 @@
+var assert = require('assert');
+
 var Base   = require('../../lib/reporters/base')
   , Assert = require('assert').AssertionError;
 
@@ -149,6 +151,27 @@ describe('Base reporter', function () {
     errOut.should.match(/\+ expected/);
   });
 
+  it('should handle error messages that are not strings', function () {
+    var errOut;
+
+    try {
+      assert(false, true);
+    } catch (err) {
+      err.actual = false;
+      err.expected = true;
+      err.showDiff = true;
+      var test = makeTest(err);
+
+      Base.list([test]);
+
+      errOut = stdout.join('\n');
+      errOut.should.match(/\+true/);
+      errOut.should.match(/\-false/);
+      errOut.should.match(/\- actual/);
+      errOut.should.match(/\+ expected/);
+    }
+  });
+
   it('should remove message from stack', function () {
     var err = {
       message: 'Error',