Non string error messages #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about: if (err.message && typeof err.message.toString === 'function') {
message = err.message + '';
} ...Then we handle other non-string messages that can be coerced. |
|
@danielstjules great idea! I'll change it. |
jkimbo
force-pushed
the
non-string-error-messages
branch
from
e1e6885
to
3e2194b
Compare
|
Thanks! Could you rebase/squash? :) |
jkimbo
force-pushed
the
non-string-error-messages
branch
from
bfa8125
to
e0a43d2
Compare
|
@danielstjules done! |
danielstjules
added a commit
that referenced
this pull request
Feb 19, 2016
Non string error messages
|
Thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks that when handling assertion error messages in a reporter, the message is actually a string since if it isn't the
message.matchfunction (https://github.com/jkimbo/mocha/blob/2a1dc7a8f32d7eb65cdf645c30aac3cc37714ae7/lib/reporters/base.js#L208) fails and leads to the test suite failing silently.