throw exception if --forbid-only option is set even if suite is not s…

…elected by grep
mochajs · May 5, 2020 · f871782 · f871782
1 parent c2c8dc8
commit f871782
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/lib/interfaces/common.js b/lib/interfaces/common.js
@@ -93,6 +93,9 @@ module.exports = function(suites, context, mocha) {
        * @returns {Suite}
        */
       only: function only(opts) {
+        if (mocha.options.forbidOnly) {
+          throw createUnsupportedError('`.only` forbidden');
+        }
         opts.isOnly = true;
         return this.create(opts);
       },
@@ -126,11 +129,7 @@ module.exports = function(suites, context, mocha) {
         suite.file = opts.file;
         suites.unshift(suite);
         if (opts.isOnly) {
-          if (mocha.options.forbidOnly && shouldBeTested(suite)) {
-            throw createUnsupportedError('`.only` forbidden');
-          }
-
-          suite.parent.appendOnlySuite(suite);
+          suite.markOnly();
         }
         if (suite.pending) {
           if (mocha.options.forbidPending && shouldBeTested(suite)) {