Merge 8736b46 into a9f3526

mochajs · Dec 22, 2018 · ff5bdbe · ff5bdbe
2 parents a9f3526 + 8736b46
commit ff5bdbe
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/mocha.js b/lib/mocha.js
@@ -781,10 +781,11 @@ Mocha.prototype.run = function(fn) {
   exports.reporters.Base.hideDiff = options.hideDiff;
 
   function done(failures) {
+    fn = fn || function fn() {};
     if (reporter.done) {
       reporter.done(failures, fn);
     } else {
-      fn && fn(failures);
+      fn(failures);
     }
   }
 

diff --git a/test/unit/mocha.spec.js b/test/unit/mocha.spec.js
@@ -56,6 +56,20 @@ describe('Mocha', function() {
     });
   });
 
+  describe('.reporter("xunit").run(fn)', function() {
+    it('should not raise errors if callback was not provided', function() {
+      var mocha = new Mocha();
+      expect(function() {
+        try {
+          mocha.reporter('xunit').run();
+        } catch (e) {
+          console.log(e);
+          expect.fail(e.message);
+        }
+      }, 'not to throw');
+    });
+  });
+
   describe('.addFile()', function() {
     it('should add the given file to the files array', function() {
       var mocha = new Mocha(opts);