add Runnable.globals(arr) method for per test global whitelist #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of suite wide whitelisting of global leaks, this allows for individual tests to whitelist globals. This allows for keeping global detection for tests which are not expected to set globals while allowing for certain globals if the author expects a test to set globals
|
Any thoughts on this PR? I would like this functionality for some browser tests in engine.io-client which need to whitelist per test globals. |
|
SGTM |
travisjeffery
pushed a commit
that referenced
this pull request
Dec 6, 2013
add Runnable.globals(arr) method for per test global whitelist
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of suite wide whitelisting of global leaks, this allows for
individual tests to whitelist globals. This allows for keeping global
detection for tests which are not expected to set globals while allowing
for certain globals if the author expects a test to set globals