Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff Viewer Verbosity with -0 #1229

Closed
skeggse opened this issue May 28, 2014 · 6 comments
Closed

Diff Viewer Verbosity with -0 #1229

skeggse opened this issue May 28, 2014 · 6 comments

Comments

@skeggse
Copy link
Contributor

skeggse commented May 28, 2014

As per chaijs/chai#223, it might make sense to display -0 in mocha's diff viewer if the value is actually -0 and not +0.

Thoughts?
@boneskull
Copy link
Member

Appears to be a Chai bug.

@skeggse
Copy link
Contributor Author

skeggse commented Aug 26, 2014

@boneskull I think this issue still applies. Mocha's diff viewer should display -0 as such, instead of displaying it as 0.

@boneskull boneskull reopened this Aug 27, 2014
@boneskull
Copy link
Member

Sorry, misunderstood the issue. This makes sense.

@jbnicolai
Copy link

👍

@a8m a8m mentioned this issue Jan 7, 2015
Merged
travisjeffery pushed a commit that referenced this issue Jan 18, 2015
Merge pull request #1493 from a8m/master
e130e31 
[Fix]: Diff viewer(#1229, #1132, ...)
@a8m
Copy link
Contributor

a8m commented Jan 18, 2015

fixed! see: #1493
/cc @boneskull @jbnicolai

@jbnicolai
Copy link

@a8m fantastic!

@boneskull boneskull removed the status: accepting prs Mocha can use your help with this one! label Oct 10, 2016
@snyk-bot snyk-bot mentioned this issue Mar 12, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 29, 2021
Open
@snyk-bot snyk-bot mentioned this issue Sep 16, 2021
Open
@snyk-bot snyk-bot mentioned this issue Jan 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@boneskull @skeggse @jbnicolai @a8m