Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.timeout(0) does not disable 'timeout as test error' #1321

Closed
breathe opened this issue Aug 23, 2014 · 6 comments
Closed

this.timeout(0) does not disable 'timeout as test error' #1321

breathe opened this issue Aug 23, 2014 · 6 comments

Comments

@breathe
Copy link

breathe commented Aug 23, 2014

The documentation says that test timeouts can be disabled with 'this.timeout(0)' -- however my test fails after timing out in 0ms ...

mocha lib\tests\test_winhelper.js

wim module:
1) "before all" hook

0 passing (920ms)
1 failing

  1. wim module: "before all" hook:
    Error: timeout of 0ms exceeded
    at done (c:\win-projects\winlib\node_modules\mocha\lib\runnable.js:204:67)
    at callFn (c:\win-projects\winlib\node_modules\mocha\lib\runnable.js:260:7)
    at Hook.Runnable.run (c:\win-projects\winlib\node_modules\mocha\lib\runnablele.js:242:7)
    at next (c:\win-projects\winlib\node_modules\mocha\lib\runner.js:258:10)
    at Object._onImmediate (c:\win-projects\winlib\node_modules\mocha\lib\runner.js:275:5)
    at processImmediate as _immediateCallback

npm ERR! Test failed. See above for more details.
npm ERR! not ok code 0

node v0.10.28 on win7 x64 with mocha 1.21.4

@boneskull
Copy link
Member

fixed in 35da58b#diff-d41d8cd98f00b204e9800998ecf8427e

please search issues before posting

@juuxstar
Copy link

I see that #1300 has resolved this issue and you bumped the version number, but the main mocha.js does not look like it's been rebuilt and committed to the 1.2.14 tag.

https://github.com/visionmedia/mocha/blob/1.21.4/mocha.js#L4204

still doesn't have the new fix.
Can you confirm it's been rebuilt?

@boneskull
Copy link
Member

@juuxstar Once a changeset is tagged, the tag doesn't change. Thus, 1.21.4 will always be 1.21.4.

So if you would like this fix, you'll need to git clone this repo until we publish a new version.

@hlobil
Copy link

hlobil commented Sep 24, 2014

It appears to have been fixed two month ago. A new release build would be nice.

@boneskull
Copy link
Member

@travisjeffery Perhaps we should release

@travisjeffery
Copy link
Contributor

sounds good i'll take a look at everything and put out a release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants