-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this.timeout(0) does not disable 'timeout as test error' #1321
Comments
fixed in 35da58b#diff-d41d8cd98f00b204e9800998ecf8427e please search issues before posting |
I see that #1300 has resolved this issue and you bumped the version number, but the main mocha.js does not look like it's been rebuilt and committed to the 1.2.14 tag. https://github.com/visionmedia/mocha/blob/1.21.4/mocha.js#L4204 still doesn't have the new fix. |
@juuxstar Once a changeset is tagged, the tag doesn't change. Thus, 1.21.4 will always be 1.21.4. So if you would like this fix, you'll need to |
It appears to have been fixed two month ago. A new release build would be nice. |
@travisjeffery Perhaps we should release |
sounds good i'll take a look at everything and put out a release soon |
The documentation says that test timeouts can be disabled with 'this.timeout(0)' -- however my test fails after timing out in 0ms ...
wim module:
1) "before all" hook
0 passing (920ms)
1 failing
Error: timeout of 0ms exceeded
at done (c:\win-projects\winlib\node_modules\mocha\lib\runnable.js:204:67)
at callFn (c:\win-projects\winlib\node_modules\mocha\lib\runnable.js:260:7)
at Hook.Runnable.run (c:\win-projects\winlib\node_modules\mocha\lib\runnablele.js:242:7)
at next (c:\win-projects\winlib\node_modules\mocha\lib\runner.js:258:10)
at Object._onImmediate (c:\win-projects\winlib\node_modules\mocha\lib\runner.js:275:5)
at processImmediate as _immediateCallback
npm ERR! Test failed. See above for more details.
npm ERR! not ok code 0
node v0.10.28 on win7 x64 with mocha 1.21.4
The text was updated successfully, but these errors were encountered: