throw undefined

[disjukr]

it('expected', function () {
    throw 'foo';
});
it('unexpected', function () {
    throw undefined;
});

then

  1) expected
  ✓ unexpected

in 1.21.5

[dasilvacontin]

I'm working on this issue right now.

I agree that throwing undefined should make the test fail. What about throwing null?

Current behaviour is: a test passes if thrown either undefined or null. UNLESS you are throwing async on an async test, due to Runner.prototype.uncaught. It even generates an error with the message 'Caught undefined error, did you throw without specifying what?'. Only failing in that case must not be an intended behaviour.

Checking if the thrown exception is undefined can only be done in the catch block, since passing undefined to the callback means 'no error here'. (Well, you could pass to the callback a reference to a global object that means undefined, and then check the reference later, but that's quite ugly)

I made changes so that throwing undefined or null makes the test fail. However, it breaks the following project test case (line 228 at test/runnable.js):
Runnable(title, fn), .run(fn), when async, when an exception is thrown, should not throw its own exception if passed a non-object.

If I make it so that throwing null doesn't make a test fail whereas throwing undefined does make a test fail, the Runnable project test case does not break. But that's because it only checks throwing null, and not throwing undefined, which I believe is also a non-object.

I will send a PR with some changes and new tests. I'm marking as pending the Runnable test that breaks until we decide something.

IMO, if you are throwing, it should make the test fail.

[boneskull]

Agreed; if anything is thrown, the test should fail.

[boneskull]

@travisjeffery Looking for your feedback here if you have any.

[dasilvacontin]

See #1410.