Nyan Reporter ignores useColors

[shellscape]

Just what the title says. Nyan reporter is (understandably) doing a lot with colors. Unfortunately it ignores the useColors configuration altogether and outputs directly to process.stdout. From looking at the code, I understand it may be complex to honor that setting. The rest of the output from mocha honors that setting, it's just the reporter that doesn't.

Running a stripcolors function on the output before process.stdout.write in the write method might be an acceptable solution for a configuration that's probably not used very often.

[dasilvacontin]

I think it can easily be solved by modifying both NyanCat.prototype.rainbowify and NyanCat.prototype.drawScoreboard.

[dasilvacontin]

Nasty thing, Mocha.prototype.useColors is defaulting to true when no preference is given, overwriting later the default value in Base.useColors, that was smartly checking if the terminal is a tty.

[dasilvacontin]

What I mentioned is related to #1452.

[dasilvacontin]

See PR #1469.

[shellscape]

thank you for the work on this one @dasilvacontin

[dasilvacontin]

You're welcome, @shellscape!