Mocha.run throws a TypeError if callback is not provided

[flowersinthesand]

To reproduce the issue, install Mocha 2.1.0 and run this script on Node console.

var Mocha = require("mocha");
var mocha = new Mocha();
mocha.addFile("./test.js");
mocha.run();

Here is test.js

it("nothing", function() {});

Then, I get:

Donghwan@DONGHWAN ~/Documents/GitHub/vibe-javascript-client (master)
$ node test-runner


  √ nothing

  1 passing (7ms)


c:\Users\Donghwan\Documents\GitHub\vibe-javascript-client\node_modules\mocha\lib\mocha.js:414
          fn(failures);
          ^
TypeError: undefined is not a function
    at done (c:\Users\Donghwan\Documents\GitHub\vibe-javascript-client\node_modules\mocha\lib\mocha.js:414:11)
    at Runner.<anonymous> (c:\Users\Donghwan\Documents\GitHub\vibe-javascript-client\node_modules\mocha\lib\runner.js:590:5)
    at Runner.emit (events.js:117:20)
    at c:\Users\Donghwan\Documents\GitHub\vibe-javascript-client\node_modules\mocha\lib\runner.js:597:10
    at c:\Users\Donghwan\Documents\GitHub\vibe-javascript-client\node_modules\mocha\lib\runner.js:518:7
    at next (c:\Users\Donghwan\Documents\GitHub\vibe-javascript-client\node_modules\mocha\lib\runner.js:248:23)
    at Object._onImmediate (c:\Users\Donghwan\Documents\GitHub\vibe-javascript-client\node_modules\mocha\lib\runner.js:276:5)
    at processImmediate [as _immediateCallback] (timers.js:345:15)

2.0.1 works fine. As the wiki page shows use of mocha.run(), I think it's a regression in 2.1.0. A workaround is to pass an empty callback.

It looks like that 30582e6 is the cause. Before executing fn(failures);, it should check if fn is available.

[julien-f]

Same issue here, the workaround solved it for now.

[flowersinthesand]

@dasilvacontin As @julien-f experienced the same issue, you may want to change the label, unconfirmed, to something like invalid or bug?

[dasilvacontin]

Sure, thanks for the heads up, @flowersinthesand!

[dasilvacontin]

PR #1520 fixes this issue.

[OKNoah]

Will there be a release with this in it?