Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when grepping don't display the empty suites #166

Closed
tj opened this issue Dec 19, 2011 · 3 comments
Closed

when grepping don't display the empty suites #166

tj opened this issue Dec 19, 2011 · 3 comments
Labels
type: feature enhancement proposal

Comments

@tj
Copy link
Contributor

tj commented Dec 19, 2011

No description provided.

@uipoet
Copy link

uipoet commented Mar 23, 2012

Just discovered --grep and glad that you already know about this issue. I think it may be worth showing an example for exact matching using ^. I was having an unintended test fire because it included part of a word that I was only looking for exactly in a description.

antoviaque added a commit to antoviaque/mocha that referenced this issue Apr 9, 2012
@antoviaque
Fixes mochajs#166 - When grepping don't display the empty suites
cd186e0 
Don't emit the 'suite' event if the suite doesn't contain tests matching
the grep expression.
@antoviaque antoviaque mentioned this issue Apr 9, 2012
Merged
antoviaque added a commit to antoviaque/mocha that referenced this issue Apr 10, 2012
@antoviaque
Fixes mochajs#124 and fixes mochajs#166 - Changes the name of the sui…
0b7b6f6 
…te.iterateTests()

function to suite.eachTest(), and replaces forEach by util.forEach()
for browser compatibility.
tj added a commit that referenced this issue Apr 10, 2012
@tj
Merge pull request #368 from antoviaque/issue124
2e56414 
Fixes issues #124 and #166 - Proper display of suites/tests count when using --grep
brendannee pushed a commit to brendannee/mocha that referenced this issue Apr 10, 2012
@antoviaque @tj
Fixes mochajs#166 - When grepping don't display the empty suites
0dbc43a 
Don't emit the 'suite' event if the suite doesn't contain tests matching
the grep expression.
brendannee pushed a commit to brendannee/mocha that referenced this issue Apr 10, 2012
@antoviaque @tj
Fixes mochajs#124 and fixes mochajs#166 - Changes the name of the sui…
5be944a 
…te.iterateTests() function to suite.eachTest(), and replaces forEach by util.forEach() for browser compatibility.
@brendannee
Copy link
Contributor

This issue should be closed, right?

@tj
Copy link
Contributor Author

tj commented Apr 13, 2012

yup

@tj tj closed this as completed Apr 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature enhancement proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tj @brendannee @uipoet