Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors not working correctly #2071

Closed
thedark1337 opened this issue Jan 26, 2016 · 4 comments
Closed

Colors not working correctly #2071

thedark1337 opened this issue Jan 26, 2016 · 4 comments

Comments

@thedark1337
Copy link
Contributor

In version 2.3.4 the colors were working fine. The commit that added in Chalk doesn't work.

Mocha 2.3.4: Mocha 2.3.4

Mocha 2.4.1: Mocha 2.4.1

Removing the String '\u001b[' + from the return '\u001b[' + exports.colors[type] + 'm' + str + '\u001b[0m'; , the output shows fine as seen here:

Mocha 2.4.1 Fixed

Using cmder with powershell on Windows 10

Currently works fine as well on Linux and removing the code also works fine.

@danielstjules
Copy link
Contributor

@boneskull It may be worth reverting/removing chalk? Here's another comment mentioning this issue: 1192914#commitcomment-15689799

However, I've been unable to reproduce the issue so far.

@thedark1337
Copy link
Contributor Author

Just removing the String '\u001b[' + fixes the issue, as was commented as well on that commit @danielstjules

@danielstjules
Copy link
Contributor

I suppose that's ideal, since using Chalk helped close issues regarding mocha's color output :)

@danielstjules
Copy link
Contributor

A PR would be appreciated!

boneskull added a commit that referenced this issue Jan 26, 2016
Fix #2071: Removed color code to fix Chalk colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants